Skip to content

🐛 Send conversation message notifications to users #7964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 24, 2025
Merged

🐛 Send conversation message notifications to users #7964

merged 2 commits into from
Jun 24, 2025

Conversation

@giancarloromeo
Copy link
Contributor

@giancarloromeo giancarloromeo commented Jun 24, 2025 •
edited
Loading

What do these changes do?

This PR fixes the method called to send notifications for conversation messages.

Related issue/s

How to test

Dev-ops

@giancarloromeo giancarloromeo added this to the Engage milestone Jun 24, 2025
@giancarloromeo giancarloromeo self-assigned this Jun 24, 2025
@giancarloromeo giancarloromeo added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected labels Jun 24, 2025
@codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.95%. Comparing base (dd8161e) to head (4e74af0).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7964      +/-   ##
==========================================
- Coverage   87.83%   84.95%   -2.88%     
==========================================
  Files        1849      692    -1157     
  Lines       71333    32719   -38614     
  Branches     1250      176    -1074     
==========================================
- Hits        62654    27798   -34856     
+ Misses       8317     4863    -3454     
+ Partials      362       58     -304
Flag Coverage Δ
integrationtests 64.25% <83.33%> (+0.02%) ⬆️
unittests 86.80% <83.33%> (+0.37%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_celery_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 77.10% <ø> (-7.95%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.65% <ø> (-13.42%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.33% <ø> (-1.77%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 87.59% <83.33%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd8161e...4e74af0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giancarloromeo giancarloromeo marked this pull request as ready for review June 24, 2025 11:57
@giancarloromeo giancarloromeo requested a review from odeimaiz June 24, 2025 11:57
odeimaiz
odeimaiz approved these changes Jun 24, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@giancarloromeo giancarloromeo merged commit 0571243 into ITISFoundation:master Jun 24, 2025
95 of 97 checks passed
@giancarloromeo giancarloromeo deleted the fix-converation-message-ws-events-recipients branch June 24, 2025 14:07
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

@GitHK GitHK Awaiting requested review from GitHK GitHK is a code owner

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66 matusdrobuliak66 is a code owner

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@giancarloromeo giancarloromeo

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs bug buggy, it does not work as expected

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

3 participants

@giancarloromeo @pcrespov @odeimaiz